Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a digit separator #1699

Closed
wants to merge 3 commits into from
Closed

Add support for a digit separator #1699

wants to merge 3 commits into from

Conversation

tpunt
Copy link
Contributor

@tpunt tpunt commented Dec 28, 2015

nikic
nikic reviewed Dec 28, 2015
View reviewed changes
Zend/zend_language_scanner.l
int len = yyleng - 2;
char *end;
char *end, *bin = strndup(yytext + 2, len);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this freed again? Also, should use estrndup. It would also be good point to avoid copying the string if it does not have digit separators.

@smalyshev smalyshev added the RFC label Dec 29, 2015
@tpunt tpunt force-pushed the number-format-separator branch from b03c616 to 53aa68d Compare December 30, 2015 10:05
@tpunt tpunt closed this Dec 30, 2015
@tpunt tpunt force-pushed the number-format-separator branch from af5604a to 65e456f Compare December 30, 2015 13:11
@tpunt tpunt reopened this Dec 30, 2015
@tpunt tpunt force-pushed the number-format-separator branch 4 times, most recently from 40a6d87 to 61f5aab Compare December 31, 2015 19:38
@tpunt tpunt force-pushed the number-format-separator branch from 9f820c6 to 3580086 Compare January 1, 2016 00:50
@tpunt tpunt closed this Jan 1, 2016
@tpunt tpunt reopened this Jan 1, 2016
@tpunt
Copy link
Contributor Author

tpunt commented Jan 25, 2016

This feature has been rejected with a final vote of 20:18 (yes:no).

@tpunt tpunt closed this Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpunt @nikic @smalyshev